Add logs to check if the second simulation fails #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouseless0x
approved these changes
Oct 18, 2024
nikmel2803
reviewed
Oct 18, 2024
src/rpc/rpcHandler.ts
Outdated
| ) | ||
| } catch (err) { | ||
| this.logger.error({ error: err }, "Second simulations fail") |
There was a problem hiding this comment.
Suggested change
| this.logger.error({ error: err }, "Second simulations fail") | |
| this.logger.error({ err }, "Second simulations fail") |
we should use err for logging an Error: https://getpino.io/#/docs/api?id=mergingobject-object
If the object is of type Error, it is wrapped in an object containing a property err ({ err: mergingObject }). This allows for a unified error handling flow.
or just this.logger.error(err, "Second simulations fail")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.