Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main: update variable.Version equals to ServerVersion which set in the configuration file(#27210) #27731

Merged
merged 2 commits into from
Sep 2, 2021
Merged

main: update variable.Version equals to ServerVersion which set in the configuration file(#27210) #27731

merged 2 commits into from
Sep 2, 2021

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 1, 2021 •
edited by morgo
Loading

What problem does this PR solve?

Issue Number: close #27210

Check List

Tests

  • Unit test

Release note 

fix #27210, update variable.Version after load configuration, let select @@version equals to select VERSION().

@Defined2014 Defined2014 requested a review from a team September 1, 2021 10:11
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 1, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2021
@Defined2014
Copy link
Contributor Author

/cc @morgo PTAL

@ti-chi-bot
Copy link
Member

@Defined2014: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @morgo PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/cc @tiancaiamao @zimulala
PTAL

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2021
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 2, 2021
@morgo
Copy link
Contributor

morgo commented Sep 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 850f9eb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2021
@ti-chi-bot ti-chi-bot merged commit 207eb3b into pingcap:master Sep 2, 2021
@Defined2014 Defined2014 deleted the issue-#27210 branch September 2, 2021 03:42
@Defined2014 Defined2014 mentioned this pull request Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@morgo morgo morgo approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting the version for TiDB doesn't reflect on global vars
4 participants
@Defined2014 @ti-chi-bot @morgo @xhebox