Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tables: fix resp is nil and change resp check #52035

Merged
merged 2 commits into from
Mar 25, 2024
Merged

tables: fix resp is nil and change resp check #52035

merged 2 commits into from
Mar 25, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Mar 22, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #52034

Problem Summary:

What changed and how does it work?

check resp is nil

Check List

Tests

  • Unit test
  • Integration test
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2024
@tiprow tiprow
Copy link

tiprow bot commented Mar 22, 2024

Hi @HuSharp. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
fix nil
51edb06 
Signed-off-by: husharp <[email protected]>
@HuSharp
fix nil
a5e0a29 
Signed-off-by: husharp <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

Merging #52035 (a5e0a29) into master (07ef009) will decrease coverage by 15.9868%.
Report is 11 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #52035         +/-   ##
=================================================
- Coverage   70.6719%   54.6852%   -15.9868%     
=================================================
  Files          1481       1592        +111     
  Lines        439242     610029     +170787     
=================================================
+ Hits         310421     333596      +23175     
- Misses       109308     253250     +143942     
- Partials      19513      23183       +3670
Flag Coverage Δ
integration 36.7583% <100.0000%> (?)
unit 70.4680% <100.0000%> (-0.0188%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.2616% <ø> (+5.4331%) ⬆️

JmPotato
JmPotato approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please attach the manual test result also?

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 25, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 25, 2024

Could you please attach the manual test result also?

Test by these steps as mentioned in issue cc @mayjiang0203

step 1. down dc2 to make dr cluster change to async mode;
step 2. check table information_schema.cluster_info;

Can you add label for issue as well :)

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 25, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-25 02:58:28.892317528 +0000 UTC m=+1863935.914563911: ☑️ agreed by JmPotato.
  • 2024-03-25 03:16:39.777501215 +0000 UTC m=+1865026.799747597: ☑️ agreed by xhebox.

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 25, 2024

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, tangenta, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit b2a9a56 into pingcap:master Mar 25, 2024
22 of 23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #52053.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 25, 2024
Merged
4 tasks
@HuSharp HuSharp deleted the fix_resp_nil branch March 25, 2024 05:19
ti-chi-bot bot pushed a commit that referenced this pull request Mar 25, 2024
@ti-chi-bot
tabls: fix resp is nil and change resp check (#52035) (#52053)
99e63f1 
close #52034
@HuSharp HuSharp changed the title tabls: fix resp is nil and change resp check tables: fix resp is nil and change resp check Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@xhebox xhebox xhebox approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.0 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@HuSharp @ti-chi-bot @JmPotato @xhebox @tangenta