Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabls: fix resp is nil and change resp check (#52035) #52053

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52035

What problem does this PR solve?

Issue Number: close #52034

Problem Summary:

What changed and how does it work?

check resp is nil

Check List

Tests

  • Unit test
  • Integration test
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.0 labels Mar 25, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-25 04:16:29.791822208 +0000 UTC m=+1868616.814068595: ☑️ agreed by JmPotato.
  • 2024-03-25 04:17:56.693244953 +0000 UTC m=+1868703.715491340: ☑️ agreed by tangenta.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.0@4a4b8d6). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.0     #52053   +/-   ##
================================================
  Coverage               ?   70.6439%           
================================================
  Files                  ?       1477           
  Lines                  ?     438345           
  Branches               ?          0           
================================================
  Hits                   ?     309664           
  Misses                 ?     109216           
  Partials               ?      19465           
Flag Coverage Δ
unit 70.4336% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 45.7989% <0.0000%> (?)

@JmPotato
Copy link
Member

/test check_dev

Copy link

ti-chi-bot bot commented Mar 25, 2024

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test
  • /test pull-lightning-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-8.0/ghpr_build
  • pingcap/tidb/release-8.0/ghpr_check
  • pingcap/tidb/release-8.0/ghpr_check2
  • pingcap/tidb/release-8.0/ghpr_mysql_test
  • pingcap/tidb/release-8.0/ghpr_unit_test

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Mar 25, 2024

@JmPotato: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JmPotato
Copy link
Member

/test check-dev

@HuSharp
Copy link
Contributor

HuSharp commented Mar 25, 2024

/test check_dev

Copy link

tiprow bot commented Mar 25, 2024

@JmPotato: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 99e63f1 into pingcap:release-8.0 Mar 25, 2024
18 checks passed
@HuSharp HuSharp deleted the cherry-pick-52035-to-release-8.0 branch March 25, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants