-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: add table filter for log restore #57394
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7c04493
to
8ef978b
Compare
8ef978b
to
02a2318
Compare
02a2318
to
c29b578
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57394 +/- ##
================================================
+ Coverage 73.5240% 74.5403% +1.0162%
================================================
Files 1681 1700 +19
Lines 463969 464896 +927
================================================
+ Hits 341129 346535 +5406
+ Misses 101997 96792 -5205
- Partials 20843 21569 +726
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f624281
to
6ebc531
Compare
79e7cdb
to
1f50af7
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. |
3991258
to
08bd990
Compare
Signed-off-by: Wenqi Mou <[email protected]>
08bd990
to
852dcff
Compare
@Tristan1900: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #57613
Problem Summary:
Need table filter for PiTR
What changed and how does it work?
The following happens if a custom filter is specified during PiTR.
Performance:
we are still scanning log meta kv twice, it's just we move the previously id map building step before snapshot happens.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.