Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/stream: allow pitr to create oversized indices (#58433) #58527

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58433

What problem does this PR solve?

Issue Number: close #58430

Problem Summary:
During restoring, the internal config of BR wasn't updated.
It may reject all indices longer than the default config (3072) though the target cluster modified this config.

What changed and how does it work?

This updates the TiDB config of the BR internal TiDB instance during restoring incremental data.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that caused cannot restore index created during log backup if it is longer than `3072`.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@9a5b05a). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58527   +/-   ##
================================================
  Coverage               ?   57.0042%           
================================================
  Files                  ?       1770           
  Lines                  ?     628787           
  Branches               ?          0           
================================================
  Hits                   ?     358435           
  Misses                 ?     246184           
  Partials               ?      24168           
Flag Coverage Δ
integration 36.8079% <40.0000%> (?)
unit 72.6359% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2807% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 7, 2025
Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 03:09:15.587994242 +0000 UTC m=+236698.876825944: ☑️ agreed by YuJuncen.
  • 2025-01-07 04:01:13.619858955 +0000 UTC m=+239816.908690659: ☑️ agreed by BornChanger.

@YuJuncen
Copy link
Contributor

YuJuncen commented Jan 7, 2025

/test unit-test

Copy link

ti-chi-bot bot commented Jan 7, 2025

@YuJuncen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-unit-test-ddlv1
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-br-integration-test
/test pull-br-integration-test-centos
/test pull-check2-centos
/test pull-common-test
/test pull-common-test-centos
/test pull-e2e-test
/test pull-e2e-test-centos
/test pull-integration-common-test
/test pull-integration-common-test-centos
/test pull-integration-copr-test
/test pull-integration-copr-test-centos
/test pull-integration-ddl-test
/test pull-integration-ddl-test-centos
/test pull-integration-e2e-test
/test pull-integration-e2e-test-centos
/test pull-integration-jdbc-test
/test pull-integration-jdbc-test-centos
/test pull-integration-mysql-test
/test pull-integration-mysql-test-centos
/test pull-integration-nodejs-test
/test pull-integration-nodejs-test-centos
/test pull-integration-python-orm-test
/test pull-integration-python-orm-test-centos
/test pull-integration-tidb-tools-test
/test pull-integration-tidb-tools-test-centos
/test pull-lightning-integration-test
/test pull-lightning-integration-test-centos
/test pull-mysql-client-test
/test pull-mysql-client-test-centos
/test pull-mysql-test-centos
/test pull-sqllogic-test
/test pull-sqllogic-test-centos
/test pull-tiflash-test
/test pull-tiflash-test-centos

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-8.5/pull_build
pingcap/tidb/release-8.5/pull_check
pingcap/tidb/release-8.5/pull_check2
pingcap/tidb/release-8.5/pull_mysql_test
pingcap/tidb/release-8.5/pull_unit_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Jan 7, 2025

@YuJuncen: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Jan 7, 2025

@ti-chi-bot[bot]: No presubmit jobs available for pingcap/[email protected]

In response to this:

@YuJuncen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-unit-test-ddlv1
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-br-integration-test
/test pull-br-integration-test-centos
/test pull-check2-centos
/test pull-common-test
/test pull-common-test-centos
/test pull-e2e-test
/test pull-e2e-test-centos
/test pull-integration-common-test
/test pull-integration-common-test-centos
/test pull-integration-copr-test
/test pull-integration-copr-test-centos
/test pull-integration-ddl-test
/test pull-integration-ddl-test-centos
/test pull-integration-e2e-test
/test pull-integration-e2e-test-centos
/test pull-integration-jdbc-test
/test pull-integration-jdbc-test-centos
/test pull-integration-mysql-test
/test pull-integration-mysql-test-centos
/test pull-integration-nodejs-test
/test pull-integration-nodejs-test-centos
/test pull-integration-python-orm-test
/test pull-integration-python-orm-test-centos
/test pull-integration-tidb-tools-test
/test pull-integration-tidb-tools-test-centos
/test pull-lightning-integration-test
/test pull-lightning-integration-test-centos
/test pull-mysql-client-test
/test pull-mysql-client-test-centos
/test pull-mysql-test-centos
/test pull-sqllogic-test
/test pull-sqllogic-test-centos
/test pull-tiflash-test
/test pull-tiflash-test-centos

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-8.5/pull_build
pingcap/tidb/release-8.5/pull_check
pingcap/tidb/release-8.5/pull_check2
pingcap/tidb/release-8.5/pull_mysql_test
pingcap/tidb/release-8.5/pull_unit_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
Copy link
Contributor

YuJuncen commented Jan 7, 2025

/test unit-test

Copy link

tiprow bot commented Jan 7, 2025

@YuJuncen: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 4468f56 into pingcap:release-8.5 Jan 7, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants