Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: don't GC running TTL jobs #58644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jan 2, 2025

What problem does this PR solve?

Issue Number: close #58642

Problem Summary:

What changed and how does it work?

As mentioned in #58539, a better solution to #58510 is to not remove running TTL jobs in GC, but let the owner to finish the job.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 2, 2025
@YangKeao YangKeao changed the title ttl: dont GC running TTL jobs ttl: don't GC running TTL jobs Jan 2, 2025
@YangKeao YangKeao requested review from lcwangchao and bb7133 January 2, 2025 02:27
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 83.09859% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.5165%. Comparing base (b71ad38) to head (d7f8588).
Report is 17 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58644        +/-   ##
================================================
+ Coverage   73.1612%   73.5165%   +0.3552%     
================================================
  Files          1676       1676                
  Lines        463532     464142       +610     
================================================
+ Hits         339126     341221      +2095     
+ Misses       103600     102047      -1553     
- Partials      20806      20874        +68     
Flag Coverage Δ
integration 42.8419% <2.8169%> (?)
unit 72.3071% <83.0985%> (-0.0485%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4802% <ø> (-0.3252%) ⬇️

Copy link

ti-chi-bot bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 2, 2025
Copy link

ti-chi-bot bot commented Jan 2, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-02 03:23:04.109481194 +0000 UTC m=+579919.465485738: ☑️ agreed by lcwangchao.

Signed-off-by: Yang Keao <[email protected]>
Copy link

ti-chi-bot bot commented Jan 3, 2025

@YangKeao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 60af5b3 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't GC row in tidb_ttl_table_status if the current status is running
2 participants