Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix pitr system table inconsistency issue (#60202) #60210

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #60202

What problem does this PR solve?

Issue Number: close #60201

Problem Summary:

What changed and how does it work?

Prevent pitr to restore system table change during log backup,
only restore full snapshot to be consistent with previous version

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1 labels Mar 21, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-9.0-beta.1@a5ca5f3). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             release-9.0-beta.1     #60210   +/-   ##
=======================================================
  Coverage                      ?   74.6572%           
=======================================================
  Files                         ?       1718           
  Lines                         ?     470327           
  Branches                      ?          0           
=======================================================
  Hits                          ?     351133           
  Misses                        ?      97310           
  Partials                      ?      21884           
Flag Coverage Δ
integration 46.1436% <100.0000%> (?)
unit 72.3091% <12.5000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 62.3045% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

ti-chi-bot bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 21, 2025
Copy link

ti-chi-bot bot commented Mar 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-21 09:28:27.059897236 +0000 UTC m=+607000.744133332: ☑️ agreed by BornChanger.
  • 2025-03-21 09:42:23.885621224 +0000 UTC m=+607837.569857321: ☑️ agreed by Leavrth.

@Leavrth
Copy link
Contributor

Leavrth commented Mar 21, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit fc0ed72 into pingcap:release-9.0-beta.1 Mar 21, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants