Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Orion sensor for ClickHouse clusters/nodes #281

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

charW
Copy link
Collaborator

@charW charW commented Jun 27, 2024

About

  • Expands ClickHouse cluster and nodes classes in Orion to store more info, including shard/replica associated with each node
  • Adds a sensor that can be run periodically to update the ClickHouse cluster topology in Orion

Testing

  • Deploy a ClickHouse cluster for testing (I've used this here, deployed locally via Docker)
  • Create a test serverset file with all the nodes' info listed (<ip>:<port>); add the serverset path to the test clickhouse-server.yaml file
  • Run Orion server with the test clickhouse-server.yaml config file passed in; verify that the proper ClickHouse nodes info are being sensed in the logs
  • Add / remove nodes in the local ClickHouse cluster; also register new logical clusters (by running Replicated DDL on each involved host); verify that the correct ClickHouse nodes info are being logged

@charW charW requested a review from a team as a code owner June 27, 2024 22:59
Copy link
Contributor

@ambud ambud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me

@ambud ambud merged commit 1d9674e into clickhouse Jun 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants