Add title to checkbox to ensure service owners know they should only enable backup instance types feature with capacity-eng approval #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enable backup instance types feature with capacity-eng approval
|
I have added titles to the checkbox and its corresponding label for better clarity. Additionally, I added the information below the Backup Instance Types as the title was not very intuitive and required a 2-second hover to view. |
osoriano
reviewed
Sep 17, 2024
osoriano
previously approved these changes
Sep 17, 2024
|
@osoriano I used warning instead of danger. What do you think? ^^ |
osoriano
reviewed
Sep 18, 2024
deploy-board/deploy_board/static/js/components/clusterconfigcomponents.js
Outdated
Show resolved
Hide resolved
osoriano
previously approved these changes
Sep 18, 2024
osoriano
reviewed
Sep 18, 2024
deploy-board/deploy_board/static/js/components/clusterconfigcomponents.js
Outdated
Show resolved
Hide resolved
liyaqin1
force-pushed
the
yaqin/addCheckboxTitle
branch
from
c3cf8df
to
a642bf4
Compare
osoriano
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.