Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title to checkbox to ensure service owners know they should only enable backup instance types feature with capacity-eng approval #1717

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Add title to checkbox to ensure service owners know they should only enable backup instance types feature with capacity-eng approval #1717

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
18d76a8
Add title to checkbox to ensure service owners know they should only …
Sep 17, 2024
a2d53ac
add notable warning when enabling backup instance types
Sep 17, 2024
a97b52c
show warning
Sep 18, 2024
c8f2e75
remove duplicates
Sep 18, 2024
a642bf4
improve format
Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions deploy-board/deploy_board/static/js/components/clusterconfigcomponents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,8 @@ Vue.component("hosttype-select", {
</div>\
<div class="col-xs-1"></div>\
<div class="col-xs-3" v-if="isVisible">\
<input type="checkbox" id="checkbox" v-bind:checked="enablemultiplehosttypes" v-on:click="enabletypeschange($event.target.checked)">\
<label for="checkbox">Enable Backup instance types</label>\
<input type="checkbox" id="checkbox" title="You should only enable this feature with capacity-eng approval. Your enable/disable operation on this feature triggers a notification to capacity-eng." v-bind:checked="enablemultiplehosttypes" v-on:click="enabletypeschange($event.target.checked)">\
<label for="checkbox" title="You should only enable this feature with capacity-eng approval. Your enable/disable operation on this feature triggers a notification to capacity-eng.">Enable Backup instance types</label>\
</div></div>',
props: ['label', 'title', 'selectoptions', 'showhelp', 'small', 'selectsearch', 'retired', 'enablemultiplehosttypes', 'disablebackupinstancetypes'],
computed: {
Expand Down Expand Up @@ -585,12 +585,19 @@ Vue.component('backup-hosttypes', {
<div class="col-xs-2"></div>\
<div class="col-xs-8">\
<span class="col-xs-8" style="padding:0;">Backup Host Types In Order: {{backuphosttypes}}</span>\
<form-warning :alert-text="backupTypesWarning"></form-warning>\
</div>\
</div>',
props: ['backuphosttypes'],
computed: {
isVisible: function () {
return this.backuphosttypes !== 'None'
},
backupTypesWarning: function () {
const part1 = "You should only enable this feature with capacity-eng approval. ";
const part2 = "Your enable/disable operation on this feature triggers a notification to capacity-eng.";
const text = part1 + part2;
return text;
}
}
});
Expand Down
Loading