Fix deadlock in DataChannel with mutex unlock #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! make sure to close the peer connections in your test so it passes! Thanks. |
JoeTurki
requested changes
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3009 +/- ##
==========================================
+ Coverage 77.96% 78.08% +0.11%
==========================================
Files 89 89
Lines 10578 10580 +2
==========================================
+ Hits 8247 8261 +14
+ Misses 1840 1832 -8
+ Partials 491 487 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JoeTurki
reviewed
Jan 16, 2025
JoeTurki
approved these changes
Jan 16, 2025
Fulfill request changes in PR 3009 Close answer and assert errors in detach tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression bug introduced in commit 835ac3b, where this line was removed: 835ac3b#diff-b8da7f3e746d55a2fe2a4295ae5fe5cf76b9512d7665201285143e25ab3bd3b9L423.
Related issue #3005