Fix unable to rollout ECS first taskset #4614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <[email protected]>
khanhtc1202
requested review from
nghialv,
kentakozuka and
ffjlabo
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4614 +/- ##
==========================================
- Coverage 30.00% 29.98% -0.02%
==========================================
Files 221 221
Lines 25955 25955
==========================================
- Hits 7787 7783 -4
- Misses 17519 17523 +4
Partials 649 649
☔ View full report in Codecov by Sentry. |
ffjlabo
reviewed
Oct 12, 2023
Comment on lines
278
to
280
| var taskSets []*types.TaskSet | ||
| if len(activeTaskSetArns) == 0 { | ||
| return nil, fmt.Errorf("failed to get task sets of service %s: services empty", *service.ServiceName) | ||
| return taskSets, nil |
There was a problem hiding this comment.
imo: just return []*types.TaskSet{} and define taskSets variable to minify its scope. 👀
There was a problem hiding this comment.
And it should be better to add comment for the reason.
There was a problem hiding this comment.
Okey, I don't have strong opinion on this 👍 Let's me adopt your suggestion
Signed-off-by: khanhtc1202 <[email protected]>
khanhtc1202
added a commit
that referenced
this pull request
Oct 12, 2023
Signed-off-by: khanhtc1202 <[email protected]>
Merged
khanhtc1202
added a commit
that referenced
this pull request
Oct 12, 2023
Signed-off-by: khanhtc1202 <[email protected]>
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: moko-poi <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Nov 5, 2023
Signed-off-by: khanhtc1202 <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Follow PR #4600
Does this PR introduce a user-facing change?: