Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unable to rollout ECS first taskset #4614

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix unable to rollout ECS first taskset #4614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c7ed1
Fix unable to rollout ECS first taskset
khanhtc1202 Oct 12, 2023
8c6060c
Minify variable scope
khanhtc1202 Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/app/piped/platformprovider/ecs/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,9 @@
activeTaskSetArns = append(activeTaskSetArns, *svc.TaskSets[i].TaskSetArn)
}

// No primary or active task set found.
if len(activeTaskSetArns) == 0 {
return nil, fmt.Errorf("failed to get task sets of service %s: services empty", *service.ServiceName)
return []*types.TaskSet{}, nil

Check warning on line 280 in pkg/app/piped/platformprovider/ecs/client.go

View check run for this annotation

Codecov / codecov/patch

pkg/app/piped/platformprovider/ecs/client.go#L280 

Added line #L280 was not covered by tests
}

tsInput := &ecs.DescribeTaskSetsInput{
Expand Down
Loading