-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: github action matrix for images build #4712
feat: github action matrix for images build #4712
Conversation
3ba3787
to
b43c11c
Compare
Signed-off-by: hungran <[email protected]>
…image base Signed-off-by: hungran <[email protected]>
b43c11c
to
abfa2c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you ❤️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4712 +/- ##
==========================================
- Coverage 30.82% 30.81% -0.01%
==========================================
Files 221 221
Lines 25993 25993
==========================================
- Hits 8012 8010 -2
- Misses 17331 17332 +1
- Partials 650 651 +1 ☔ View full report in Codecov by Sentry. |
${{ env.GHCR }}/pipe-cd/helloworld:${{ env.PIPECD_VERSION }} | ||
${{ env.GCR }}/pipecd/helloworld:${{ env.PIPECD_VERSION }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks that some container images are hosted by GCR 👀
This may be because Cloud Run can use only with Artifact Registry, GCR, Docker Hub.
So it would be nice to consider for GCR 🤔
WDYT @khanhtc1202 ?
📝 memo
Cloud Run docs: https://cloud.google.com/run/docs/deploying
PRs that maybe related
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ffjlabo good catch!
if we GCR only when Cloud Run, so ideally we could bring all images to GCR
however, not sure if PipeCD want to rely on a specific vendor?
@khanhtc1202
btw, even we won't bring all the images to GCR, we could add more configuration for the matrix by this way
https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#example-adding-configurations
already push the change base on that, please check below comment
Guys, I know that it's hard to test the workflow publish build and push image by matrix from this PR |
here you are
|
Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! Here we go 🚀
@khanhtc1202 plz re-check 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you 🙏
* feat: github action matrix images build Signed-off-by: hungran <[email protected]> * naming for each CI should be more visible, add matrix for build_tool image base Signed-off-by: hungran <[email protected]> * adding configuration for matrix container registry Signed-off-by: hungran <[email protected]> * docker tag with matrix container registry Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]>
* feat: github action matrix images build Signed-off-by: hungran <[email protected]> * naming for each CI should be more visible, add matrix for build_tool image base Signed-off-by: hungran <[email protected]> * adding configuration for matrix container registry Signed-off-by: hungran <[email protected]> * docker tag with matrix container registry Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]>
* feat: github action matrix images build Signed-off-by: hungran <[email protected]> * naming for each CI should be more visible, add matrix for build_tool image base Signed-off-by: hungran <[email protected]> * adding configuration for matrix container registry Signed-off-by: hungran <[email protected]> * docker tag with matrix container registry Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]> Signed-off-by: sZma5a <[email protected]>
* feat: github action matrix images build Signed-off-by: hungran <[email protected]> * naming for each CI should be more visible, add matrix for build_tool image base Signed-off-by: hungran <[email protected]> * adding configuration for matrix container registry Signed-off-by: hungran <[email protected]> * docker tag with matrix container registry Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
What this PR does / why we need it: better DRY on images build CI
this also prepare for upgrade image base, will have flexible option to put image TAG as ARG
#4702 (comment)
another point, though that this could be better view
Which issue(s) this PR fixes:
Part of #4713
Does this PR introduce a user-facing change?: