Implement adding config hash annotation to deployments #5418
+671
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
commented
Dec 13, 2024
| // that are referenced by the workload. | ||
| // This appending ensures that the workload should be restarted when | ||
| // one of its configurations changed. | ||
| func annotateConfigHash(manifests []provider.Manifest) error { |
There was a problem hiding this comment.
I almost copied from below.
| "github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/kubernetes/provider" | ||
| ) | ||
|
|
||
| func TestAnnotateConfigHash(t *testing.T) { |
There was a problem hiding this comment.
I almost copied from below and added a testcase for Secrets
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5418 +/- ##
==========================================
+ Coverage 25.90% 25.95% +0.04%
==========================================
Files 450 451 +1
Lines 48565 48731 +166
==========================================
+ Hits 12582 12649 +67
- Misses 34994 35081 +87
- Partials 989 1001 +12 ☔ View full report in Codecov by Sentry. |
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
khanhtc1202
reviewed
Dec 13, 2024
| @@ -90,6 +90,16 @@ func MakeResourceKey(obj *unstructured.Unstructured) ResourceKey { | |||
| return k | |||
| } | |||
|
|
|||
| func (k ResourceKey) IsDeployment() bool { | |||
There was a problem hiding this comment.
Could you add test for this 👀
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement
annotateConfigHashto use Kubernetes syncWhy we need it:
We add this annotation to ensure that the workload should be restarted when one of its configurations changes.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: