Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adding config hash annotation to deployments #5418

Merged
merged 6 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 110 additions & 0 deletions pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
// Copyright 2024 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package deployment

import (
"github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/kubernetes/provider"
)

// annotateConfigHash appends a hash annotation into the workload manifests.
// The hash value is calculated by hashing the content of all configmaps/secrets
// that are referenced by the workload.
// This appending ensures that the workload should be restarted when
// one of its configurations changed.
func annotateConfigHash(manifests []provider.Manifest) error {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost copied from below.

func annotateConfigHash(manifests []provider.Manifest) error {

if len(manifests) == 0 {
return nil
}

configMaps := make(map[string]provider.Manifest)
secrets := make(map[string]provider.Manifest)
for _, m := range manifests {
if m.Key.IsConfigMap() {
configMaps[m.Key.Name] = m
continue
}
if m.Key.IsSecret() {
secrets[m.Key.Name] = m
}
}

// This application is not containing any config manifests
// so nothing to do.
if len(configMaps)+len(secrets) == 0 {
return nil
}

Check warning on line 47 in pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go

View check run for this annotation

Codecov / codecov/patch

pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go#L46-L47

Added lines #L46 - L47 were not covered by tests

for _, m := range manifests {
if m.Key.IsDeployment() {
if err := annotateConfigHashToWorkload(m, configMaps, secrets); err != nil {
return err
}

Check warning on line 53 in pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go

View check run for this annotation

Codecov / codecov/patch

pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go#L52-L53

Added lines #L52 - L53 were not covered by tests

// TODO: Add support for other workload types, such as StatefulSet, DaemonSet, etc.
}
}

return nil
}

func annotateConfigHashToWorkload(m provider.Manifest, managedConfigMaps, managedSecrets map[string]provider.Manifest) error {
configMaps := provider.FindReferencingConfigMaps(m.Body)
secrets := provider.FindReferencingSecrets(m.Body)

// The deployment is not referencing any config resources.
if len(configMaps)+len(secrets) == 0 {
return nil
}

Check warning on line 69 in pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go

View check run for this annotation

Codecov / codecov/patch

pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go#L68-L69

Added lines #L68 - L69 were not covered by tests

cfgs := make([]provider.Manifest, 0, len(configMaps)+len(secrets))
for _, cm := range configMaps {
m, ok := managedConfigMaps[cm]
if !ok {
// We do not return error here because the deployment may use
// a config resource that is not managed by PipeCD.
continue
}
cfgs = append(cfgs, m)
}
for _, s := range secrets {
m, ok := managedSecrets[s]
if !ok {
// We do not return error here because the deployment may use
// a config resource that is not managed by PipeCD.
continue

Check warning on line 86 in pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go

View check run for this annotation

Codecov / codecov/patch

pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go#L84-L86

Added lines #L84 - L86 were not covered by tests
}
cfgs = append(cfgs, m)
}

if len(cfgs) == 0 {
return nil
}

Check warning on line 93 in pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go

View check run for this annotation

Codecov / codecov/patch

pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go#L92-L93

Added lines #L92 - L93 were not covered by tests

hash, err := provider.HashManifests(cfgs)
if err != nil {
return err
}

Check warning on line 98 in pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go

View check run for this annotation

Codecov / codecov/patch

pkg/app/pipedv1/plugin/kubernetes/deployment/annotate.go#L97-L98

Added lines #L97 - L98 were not covered by tests

m.AddStringMapValues(
map[string]string{
provider.AnnotationConfigHash: hash,
},
"spec",
"template",
"metadata",
"annotations",
)
return nil
}
Loading
Loading