Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to use uber gomock #5426

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Migrate to use uber gomock #5426

merged 1 commit into from
Dec 17, 2024

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Dec 16, 2024

What this PR does:

golang/mock is archived, and the project has been migrated under uber-go. We should use the latest gomock instead

Why we need it:

Which issue(s) this PR fixes:

Part of #5429
Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <[email protected]>
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.94%. Comparing base (0e4fbc0) to head (21e9286).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5426      +/-   ##
==========================================
- Coverage   25.95%   25.94%   -0.01%     
==========================================
  Files         451      451              
  Lines       48799    48799              
==========================================
- Hits        12665    12663       -2     
- Misses      35127    35130       +3     
+ Partials     1007     1006       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍🏻

@Warashi
Copy link
Contributor

Warashi commented Dec 17, 2024

📝
After merging this PR, we have to update the line below.

pipecd/Makefile

Line 222 in 7fc6bcc

docker run --rm -v ${PWD}:/repo -it --entrypoint ./tool/codegen/codegen.sh ghcr.io/pipe-cd/codegen@sha256:3fd8e22eeab21bab2a2f6c1d2770b069922f4973465d57386d672574931943e8 /repo #v0.47.3-rc0-2-g462b842

uses: docker://ghcr.io/pipe-cd/codegen@sha256:3fd8e22eeab21bab2a2f6c1d2770b069922f4973465d57386d672574931943e8 #v0.47.3-rc0-2-g462b842

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it, thank you

Update, June 2023: This repo and tool are no longer maintained. Please see go.uber.org/mock for a maintained fork instead.

https://github.com/golang/mock

@khanhtc1202 khanhtc1202 merged commit 511ee8f into master Dec 17, 2024
25 checks passed
@khanhtc1202 khanhtc1202 deleted the update-mockgen branch December 17, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants