-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to use uber gomock #5426
Conversation
Signed-off-by: khanhtc1202 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5426 +/- ##
==========================================
- Coverage 25.95% 25.94% -0.01%
==========================================
Files 451 451
Lines 48799 48799
==========================================
- Hits 12665 12663 -2
- Misses 35127 35130 +3
+ Partials 1007 1006 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍🏻
📝 Line 222 in 7fc6bcc
pipecd/.github/workflows/gen.yaml Line 14 in 7fc6bcc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it, thank you
Update, June 2023: This repo and tool are no longer maintained. Please see go.uber.org/mock for a maintained fork instead.
What this PR does:
golang/mock is archived, and the project has been migrated under uber-go. We should use the latest gomock instead
Why we need it:
Which issue(s) this PR fixes:
Part of #5429
Does this PR introduce a user-facing change?: