Start livestatereporter on pipedv1 #5457
Open
+281
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
force-pushed
the
start-livestatereporter-on-pipedv1
branch
from
fa22a0f to
a6603eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5457 +/- ##
==========================================
+ Coverage 26.09% 26.12% +0.03%
==========================================
Files 457 457
Lines 49081 49086 +5
==========================================
+ Hits 12808 12825 +17
+ Misses 35251 35238 -13
- Partials 1022 1023 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka,
t-kikuc and
Warashi
as code owners
khanhtc1202
reviewed
Dec 26, 2024
pkg/model/application.proto
Outdated
| @@ -45,6 +45,8 @@ message Application { | |||
| string platform_provider = 15; | |||
| // The names of deploy taget where to deploy this application. | |||
| repeated string deploy_targets = 16; | |||
| // The name of plugin used to deploy this application. | |||
| string plugin = 17; | |||
There was a problem hiding this comment.
it's not a single plugin which deploys an application but it's a list of plugins do
There was a problem hiding this comment.
@khanhtc1202
Thanks, fixed it on 0c4fc0d
| @@ -36,6 +36,8 @@ type Lister interface { | |||
| ListByPlatformProvider(name string) []*model.Application | |||
| // Get retrieves a specifiec deployment for the given id. | |||
| Get(id string) (*model.Application, bool) | |||
| // ListByPluginName lists all applications for a given plugin name. | |||
| ListByPluginName(name string) []*model.Application | |||
There was a problem hiding this comment.
Should we replace the ListByPlatformProver?
There was a problem hiding this comment.
@khanhtc1202 Your right. We don't need it for now. So I removed it. 374de36
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
force-pushed
the
start-livestatereporter-on-pipedv1
branch
from
c1654db to
0c4fc0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix to start the livestatereporter when starting pipedv1.
Also, I added a plugin name field for the application model to list apps by it.
Why we need it:
These fixes are needed to start the internal reporter for each plugin.
Which issue(s) this PR fixes:
Part of #5363
Does this PR introduce a user-facing change?: