Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposed Scene.sky properties #7041

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Exposed Scene.sky properties #7041

merged 3 commits into from
Nov 5, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 16, 2024 •
edited
Loading

Scene.sky should have been public, and this PR fixes it.

Screenshot 2024-10-16 at 09 47 47 Screenshot 2024-10-16 at 09 48 01 Screenshot 2024-10-16 at 09 48 08

@mvaligursky mvaligursky self-assigned this Oct 16, 2024
@mvaligursky mvaligursky requested a review from a team October 16, 2024 08:47
@willeastcott
Copy link
Contributor

willeastcott commented Oct 16, 2024 •
edited
Loading

What do we do about:

@mvaligursky
Copy link
Contributor Author

What do we do about:

Leave it for another PR.

@mvaligursky mvaligursky added the docs Documentation related label Nov 4, 2024
@mvaligursky
Copy link
Contributor Author

@willeastcott any objections to merge this?

willeastcott
willeastcott approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, go for it, but sky API needs a concerted clean up! 🧹

@mvaligursky mvaligursky merged commit 641ee34 into main Nov 5, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-sky-docs branch November 5, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott