Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility of engine v1 with data format of engine v2 #7066

Merged
merged 10 commits into from
Nov 4, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 25, 2024

  • In the engine v2 standard material data json file, the following tint parameters are being removed by the editor, and are always assumed to be true. If the engine v1 finds these parameters missing in the json file, they are set to true.
ambientTint
emissiveTint
diffuseTint
sheenTint
  • StandardMaterial.useGamma gets forwarded to StandardMaterial.useGammaTonemap
  • using two files to separate the code from the engine as much as possible while avoiding circular references
  • few tint parameters now default to true to match the v2 behaviour and those flags being removed from the material asset by the Editor migration soon

@mvaligursky mvaligursky self-assigned this Oct 25, 2024
@mvaligursky mvaligursky requested a review from a team October 25, 2024 12:58
@mvaligursky mvaligursky changed the title Compatibility of engine v1 with useGamma parameter from v2 Compatibility of engine v1 with data format of engine v2 Nov 4, 2024
@mvaligursky mvaligursky changed the title Compatibility of engine v1 with data format of engine v2 [BREAKING] Compatibility of engine v1 with data format of engine v2 Nov 4, 2024
Copy link
Contributor

@kpal81xd kpal81xd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure unit tests pass

@mvaligursky mvaligursky changed the title [BREAKING] Compatibility of engine v1 with data format of engine v2 Compatibility of engine v1 with data format of engine v2 Nov 4, 2024
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mvaligursky
Copy link
Contributor Author

Make sure unit tests pass

Of course, that blocks the merge.

@mvaligursky mvaligursky merged commit 6806de8 into main_v1 Nov 4, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-v1-useGamma branch November 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants