Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix frequent shader variant invalidation #7294

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 17, 2025

Fix long term problem made worse in #7284

Basically:

  • Material.chunks getter marks material as dirty, not only setter, as we don't know if chunks will be modified even then
  • ShadowRenderer calls this getter, even though it only tests for its existence, invalidating variants
  • now that all materials have chunks, this test can be removed

@mvaligursky mvaligursky merged commit 1923eb6 into main Jan 20, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-variants-invalidation branch January 20, 2025 09:48
mvaligursky added a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants