Refactoring fo envMultiply and envConst chunks #7399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
approved these changes
Mar 4, 2025
willeastcott
reviewed
Mar 4, 2025
| @@ -0,0 +1,13 @@ | |||
| export default /* wgsl */` | |||
| #ifdef LIT_SKYBOX_INTENSITY | |||
There was a problem hiding this comment.
It is worth having a shader variant just to avoid a multiply?
There was a problem hiding this comment.
not really, but this code is slightly more complicated than I want to handle during this conversion. Ideally we add skybox intensity to material as well, and unify it all.
willeastcott
reviewed
Mar 4, 2025
| @@ -0,0 +1,13 @@ | |||
| export default /* wgsl */` | |||
There was a problem hiding this comment.
I'm not 100% keen on the envProc naming. skybox?
There was a problem hiding this comment.
we already have skybox chunk that does the skybox. This is just a small chunk used by both skybox and lit-shader
willeastcott
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged chunks and updated their use:
envMultiply and envConst -> envProc