Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to engine v2 #306

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Update to engine v2 #306

merged 1 commit into from
Oct 23, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Oct 22, 2024 •
edited
Loading

This PR updates model-viewer to engine v2 and switches to the built-in projective skybox.

Some notes:

  • double click to focus doesn't work on WebGPU. this will be addressed later as the fix likely requires an engine update.
  • the projective skybox could do with more refined controls
  • the ministats GPU timer doesn't work under WebGPU
  • gaussian splat rendering doesn't use spherical harmonics. This was an engine bug fixed in Fix gsplat material defines engine#7054. Model-viewer engine will need updating again when that PR is released.

@slimbuck slimbuck added the enhancement New feature or request label Oct 22, 2024
@slimbuck slimbuck requested a review from a team October 22, 2024 16:42
@slimbuck slimbuck self-assigned this Oct 22, 2024
mvaligursky
mvaligursky approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@slimbuck slimbuck merged commit cca22f0 into main Oct 23, 2024
2 checks passed
@slimbuck slimbuck deleted the engine-v2 branch October 23, 2024 09:27
willeastcott
willeastcott reviewed Oct 23, 2024
View reviewed changes
src/viewer.ts
Comment on lines +805 to +806
// @ts-ignore
const maxSamples = device.maxSamples;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvaligursky Should we make this public API?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I added it to my list. soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

@willeastcott willeastcott willeastcott left review comments

Assignees

@slimbuck slimbuck

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slimbuck @willeastcott @mvaligursky