Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change interface declaration type #186 #187

Merged
merged 5 commits into from
Aug 27, 2023
Merged

change interface declaration type #186 #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70a42d5
change interface declaration type #186
mamico Aug 17, 2023
8dabb6f
isort
mamico Aug 17, 2023
be93032
fix provides
mamico Aug 20, 2023
76884a3
changelog
mamico Aug 20, 2023
5ba3f01
typo
mamico Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/187.bug
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a memory leak as reported in https://github.com/plone/Products.CMFPlone/issues/3829, changing interface declaration type as suggested by @d-maurer in https://github.com/plone/plone.dexterity/issues/186 [mamico]
4 changes: 2 additions & 2 deletions plone/dexterity/content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
from zope.interface import implementer
from zope.interface.declarations import getObjectSpecification
from zope.interface.declarations import implementedBy
from zope.interface.declarations import Implements
from zope.interface.declarations import ObjectSpecificationDescriptor
from zope.interface.declarations import Provides
from zope.interface.interface import Method
from zope.schema.interfaces import IContextAwareDefaultFactory
from zope.security.interfaces import IPermission
Expand Down Expand Up @@ -193,7 +193,7 @@ def __get__(self, inst, cls=None):
return spec

dynamically_provided.append(spec)
all_spec = Implements(*dynamically_provided)
all_spec = Provides(cls, *dynamically_provided)
inst._v__providedBy__ = updated + (all_spec,)

return all_spec
Expand Down