Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change interface declaration type #186 #187

Merged
merged 5 commits into from
Aug 27, 2023
Merged

Conversation

mamico
Copy link
Member

@mamico mamico commented Aug 17, 2023

Fix a memory leak as reported in plone/Products.CMFPlone#3829, changing interface declaration type as suggested by @d-maurer in #186

@mister-roboto

This comment was marked as resolved.

@mamico
Copy link
Member Author

mamico commented Aug 20, 2023

@jenkins-plone-org please run jobs

@mamico
Copy link
Member Author

mamico commented Aug 20, 2023

@jenkins-plone-org please run jobs

@mamico mamico marked this pull request as ready for review August 20, 2023 15:48
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand the discussion and its conclusions this is the solution.

@jensens jensens merged commit c8aa125 into master Aug 27, 2023
@jensens jensens deleted the interface_declaration branch August 27, 2023 18:21
mamico added a commit that referenced this pull request Oct 6, 2023
@mamico mamico mentioned this pull request Oct 6, 2023
mauritsvanrees added a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants