Cherry-pick #7 (Project infra RGB) #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@130s can you revert this?
I reverted to commit before this and everything started working again. Edit: Looks like the build failing is not consistent across different machines, however I am still unable to get images on the topic. |
|
@shaun-edwards says to not revert, logging an issue. |
|
@130s, this one is really on me since I asked you to merge this. I logged an issue to address here: #13 In the short term, I'd like to suggest we create a branch for IR-RGB support and then revert this change as @geoffreychiou suggests on the mainline. We should then make sure all internal products link to the proper branches. After #13 is addressed, we can unify the branches again. Thoughts? @130s, @geoffreychiou |
|
I see, reverting this PR in #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #7 is merged in already, this should be mergeable once CI passes.