Fix return value is the function signature #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisinabh
reviewed
Aug 19, 2024
.tool-versions
Outdated
| @@ -1,2 +1 @@ | |||
| erlang 25.0.2 | |||
There was a problem hiding this comment.
I believe this should not be in this PR.
Comment on lines
+158
to
+159
| {:ok, ^method_id, rest} -> | ||
| decode_raw(rest, types) |
There was a problem hiding this comment.
I actually have never seen the output of a call to include the method id. Is this even needed?
There was a problem hiding this comment.
I think the split method id can be removed yes, I thought you added It for a reason but if not it can be removed.
ayrat555
reviewed
Sep 8, 2024
ayrat555
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.