refactor(HMS-4079): upgrade to PatternFly 5 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
avisiedo
requested changes
May 14, 2024
There was a problem hiding this comment.
Thanks for the change 👍
Checked locally and the frontend run correctly.
only an additional change:
- Update
.rhcicd/build_deploy.shto updateexport NODE_BUILD_VERSION=18to override the node version used for cicd platform. - Running
make container-buildit was got a situation with the number of opened files; atscripts/mk/container.mkadding the option--ulimit nofile=65535:65535when running the container engine forcontainer-buildrule fixed that scenario during the collab session (thanks for the help to check the right value 👍).
avisiedo
approved these changes
May 15, 2024
|
LGTM |
|
@pvoborni sorry 🙏 I didn't realize about the message that it needs rebase. |
|
Sorry for that conflict, it is due to #59 which I merged a few minutes ago. |
All changes in this commit were created by running: ``` npx @patternfly/pf-codemods@latest src --fix ``` It used version `@patternfly/[email protected]` Signed-off-by: Petr Vobornik <[email protected]>
Upgrade PatternFly libraries to major version 5. This caused also cascade of version bumps of other dependencies in order to work. Signed-off-by: Petr Vobornik <[email protected]>
Fixes prettier issues after the automatic code conversion by codemods. Signed-off-by: Petr Vobornik <[email protected]>
`fec` build had issues with finding `PageSectionTypes`. To make it working, it would probably be needed to update `COMPONENTS_CACHE` in `tsc-transform-imports`. It was easier to replace with string. `SampleComponent` was breaking build its props definition needed to be more explicit. Upgrade of `eslint-config-redhat-cloud-services` or related package caused that eslint failed in most PF imports with `rulesdir/forbid-pf-relative-imports` rule. Thus this rule was disabled to keep the current change small. hotReload defintion in fec config was changed as FEC warned that previous way was deprecated. Signed-off-by: Petr Vobornik <[email protected]>
This commit is result of run: ``` npx @patternfly/class-name-updater src --fix ``` That is migrationg old PF class names to v5 variants. Signed-off-by: Petr Vobornik <[email protected]>
With upgrade to PF5, the size of content of idmsvc-frontend was heigher than the space offered. I.e. scrollbars were displayed in default page even when there was not enough content or in wizard, the row with bottom buttons was not visible and required scrolling. `<Page>` component is typically a high-level container which e.g. contains also `Masthead` and `Navigation` but this is part of "chrome". So in this app, all "page" is actually just the "page content" and thus "PageGroup" is the suitable component. This change fixes the size/padding issues so scrollbars are not displayed when not needed. Signed-off-by: Petr Vobornik <[email protected]>
1. issue in DomaiList where react complained that items in iterator/map don't have unique `key`. 2. two instances of: ``` Th: Table headers must have an accessible name. If the Th is intended to be visually empty, pass in screenReaderText. If the Th contains only non-text, interactive content such as a checkbox or expand toggle, pass in an aria-label ``` Signed-off-by: Petr Vobornik <[email protected]>
As builds on 16 produces warnings:
```
npm install
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@testing-library/[email protected]',
npm WARN EBADENGINE required: { node: '>=18' },
npm WARN EBADENGINE current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }
```
Signed-off-by: Petr Vobornik <[email protected]>
|
LGTM merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings update of the whole UI to PatternFly 5. Replacement of deprecated components will be done separately.
Better to check by individual commits and also see commit messages there.
The update of PatternFly required also update of various other libraries so that the versions works across dependencies. In general I tried to bring the latest versions but in react I used the same as in front end components.