Review Bot version 2.4.0 - Fellow Scores #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bullrich
force-pushed
the
review-bot/version/2.4.0
branch
from
8e6e9fb
to
20203a1
Compare
|
/merge |
|
Enabled Available commands
For more information see the documentation |
auto-merge was automatically disabled
February 1, 2024 09:07
Head branch was pushed to by a user without write access
Bullrich
force-pushed
the
review-bot/version/2.4.0
branch
from
20203a1
to
5756756
Compare
This was referenced Feb 5, 2024
Bullrich
force-pushed
the
review-bot/version/2.4.0
branch
from
4597c09
to
2c63979
Compare
|
/merge |
|
Enabled Available commands
For more information see the documentation |
Failed to update PR ❌There was an error while trying to keep this PR You may have conflicts More info in the logs 📋 |
xlc
approved these changes
Feb 14, 2024
fellowship-merge-bot
bot
merged commit 932fc15
into
polkadot-fellows:main
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Review Bot to version 2.4.0 which contains paritytech/review-bot#110 (solved in paritytech/review-bot#113)
This resolves #93
Updated review bot to latest version which brings new changes to the fellow object:
Added new optional field to the config named
scoresthat has the score of each fellow per dan (added up to dan IX).When the rule of type
fellowshas the optional field ofminTotalScoreit will check that the score of the fellows who approved the PR sums up to that number. If it doesn't sum to that number it will fail with a custom error listing the score of each fellow for reference (and saying how many points are missing).Find a complete explanation of the new configuration here: Fellows Rule
I also added some scores to all the dans (feel free to modify them) and updated the
Relay and system filesrule to have a minimum score of 6.