SSF for 2019_Haber_Crusaders

[93Boy]

PR Checklist for modifying one or multiple existing packages

• The changes maintain the structural integrity of the affected packages.
• The checksums of the modified files in the respective POSEIDON.yml files were adjusted properly.
• Every file in the submission is correctly referenced in the relevant POSEIDON.yml files and there are no additional, supplementary files in the submission that are not documented there.

---

• The packageVersion numbers of the affected packages were increased in their POSEIDON.yml files.
• The changes were documented in the respective CHANGELOG files. If no CHANGELOG files existed previously it was added here.
• The lastModified fields of the affected POSEIDON.yml files were updated.
• The contributor fields were updated with name, email and orcid of the relevant, new contributors.

---

• All affected packages pass a validation with trident validate --fullGeno.

---

• Large genotype data files are properly tracked with Git LFS and not directly pushed to the repository. For an instruction on how to set up Git LFS please look here. If you accidentally pushed the files the wrong way you can fix it with git lfs migrate import --no-rewrite path/to/file.bed (see here).

[stschiff]

Look good, from what I can see, and Validation passes. From my end good to. @AyGhal ?

[nevrome]

• The checklists above are used incorrectly. The new package list does not apply here at all and the modifying checklist is filled only partially. I will explain these checklists once more in our next meeting on Friday, as they seem to be a major point of confusion.
• The .ssf file added here has a Poseidon_IDs, but not the necessary poseidon_IDs column. That means the file is not properly linked to the package. The column must be renamed. This issue is reported in the GitHub action trident validate log:

[Warning] [2024-01-18 19:40:55] Potential consistency issues in file data/2019_Haber_Crusaders/ENAtable.ssf: The poseidon_IDs column is completely empty. Package and .ssf file are not linked

[stschiff]

Oh man, that's embarassing for me, as I've signed this off before. OK, @93Boy, please

1. go through the PR text above (take a look at the raw Markdown, where Clemens have put helpful comments) and remove the bits that are irrelevant for an existing package.
2. Make the required changes to the SSF file as indicated by Clemens.
3. I've marked this as Draft. Please mark it for review whenever you're ready.

[stschiff]

@AyGhal this is good to merge, please!

[AyGhal]

Looks great!