Skip to content

Commit

Permalink
fix pr push wflow
Browse files Browse the repository at this point in the history
  • Loading branch information
midleman committed Dec 9, 2024
1 parent 60900f5 commit 6f1c83b
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 27 deletions.
45 changes: 22 additions & 23 deletions .github/workflows/e2e-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,16 @@ on:
- always

jobs:
# e2e-electron:
# name: test
# if: ${{ inputs.run_e2e_linux == true || inputs.run_e2e_linux == null }}
# uses: ./.github/workflows/e2e-linux.yml
# with:
# grep: "@dummy-test"
# project: "e2e-electron"
# display_name: "e2e-electron"
# currents_tags: "@nightly,@electron/linux"
# secrets: inherit
e2e-electron:
name: test
if: ${{ inputs.run_e2e_linux == true || inputs.run_e2e_linux == null }}
uses: ./.github/workflows/e2e-linux.yml
with:
grep: "@dummy-test"
project: "e2e-electron"
display_name: "e2e-electron"
currents_tags: "@nightly,@electron/linux"
secrets: inherit

e2e-windows:
name: test
Expand All @@ -55,25 +55,24 @@ jobs:
currents_tags: "@nightly,@electron/win"
secrets: inherit

# e2e-browser:
# name: test
# if: ${{ inputs.run_e2e_browser == true || inputs.run_e2e_browser == null }}
# uses: ./.github/workflows/e2e-linux.yml
# with:
# grep: "@dummy-test"
# project: "e2e-browser"
# display_name: "e2e-browser"
# currents_tags: "@nightly,@browser/linux"
# secrets: inherit
e2e-browser:
name: test
if: ${{ inputs.run_e2e_browser == true || inputs.run_e2e_browser == null }}
uses: ./.github/workflows/e2e-linux.yml
with:
grep: "@dummy-test"
project: "e2e-browser"
display_name: "e2e-browser"
currents_tags: "@nightly,@browser/linux"
secrets: inherit

slack-notify:
# needs: [e2e-electron, e2e-windows, e2e-browser]
needs: [e2e-windows]
needs: [e2e-electron, e2e-windows, e2e-browser]
runs-on: ubuntu-latest
if: always()
steps:
- name: Notify Slack
uses: midleman/slack-workflow-status@master\
uses: midleman/slack-workflow-status@master
with:
repo_token: ${{ secrets.POSITRON_GITHUB_PAT }}
slack_webhook_url: ${{ secrets.SLACK_MARIE_WEBHOOK_URL }}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pr-merge-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ jobs:
name: test
uses: ./.github/workflows/e2e-linux.yml
with:
grep: "@pr"
grep: ${{ github.event_name == 'pull_request' && '@pr' || github.event_name == 'push' && '' }}
project: "e2e-electron"
display_name: "e2e-electron"
currents_tags: ${{ github.event_name == 'pull_request' && '@pr' || github.event_name == 'push' && '@push' }}
secrets: inherit

unit-tests:
Expand Down
6 changes: 3 additions & 3 deletions build/secrets/.secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
"filename": ".github/workflows/e2e-nightly.yml",
"hashed_secret": "3e26d6750975d678acb8fa35a0f69237881576b0",
"is_verified": false,
"line_number": 56
"line_number": 46
}
],
".github/workflows/pr-merge-push.yml": [
Expand All @@ -148,7 +148,7 @@
"filename": ".github/workflows/pr-merge-push.yml",
"hashed_secret": "3e26d6750975d678acb8fa35a0f69237881576b0",
"is_verified": false,
"line_number": 25
"line_number": 26
}
],
"build/azure-pipelines/alpine/product-build-alpine.yml": [
Expand Down Expand Up @@ -1924,5 +1924,5 @@
}
]
},
"generated_at": "2024-12-09T16:32:29Z"
"generated_at": "2024-12-09T17:01:40Z"
}

0 comments on commit 6f1c83b

Please sign in to comment.