fix pr push wflow

posit-dev · Dec 9, 2024 · f955bf3 · f955bf3
1 parent 60900f5
commit f955bf3
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 24 deletions.
diff --git a/.github/workflows/e2e-nightly.yml b/.github/workflows/e2e-nightly.yml
@@ -34,16 +34,16 @@ on:
               - always
 
 jobs:
-  # e2e-electron:
-  #   name: test
-  #   if: ${{ inputs.run_e2e_linux == true || inputs.run_e2e_linux == null }}
-  #   uses: ./.github/workflows/e2e-linux.yml
-  #   with:
-  #     grep: "@dummy-test"
-  #     project: "e2e-electron"
-  #     display_name: "e2e-electron"
-  #     currents_tags: "@nightly,@electron/linux"
-  #   secrets: inherit
+  e2e-electron:
+    name: test
+    if: ${{ inputs.run_e2e_linux == true || inputs.run_e2e_linux == null }}
+    uses: ./.github/workflows/e2e-linux.yml
+    with:
+      grep: "@dummy-test"
+      project: "e2e-electron"
+      display_name: "e2e-electron"
+      currents_tags: "@nightly,@electron/linux"
+    secrets: inherit
 
   e2e-windows:
     name: test
@@ -55,25 +55,24 @@ jobs:
       currents_tags: "@nightly,@electron/win"
     secrets: inherit
 
-  # e2e-browser:
-  #   name: test
-  #   if: ${{ inputs.run_e2e_browser == true || inputs.run_e2e_browser == null }}
-  #   uses: ./.github/workflows/e2e-linux.yml
-  #   with:
-  #     grep: "@dummy-test"
-  #     project: "e2e-browser"
-  #     display_name: "e2e-browser"
-  #     currents_tags: "@nightly,@browser/linux"
-  #   secrets: inherit
+  e2e-browser:
+    name: test
+    if: ${{ inputs.run_e2e_browser == true || inputs.run_e2e_browser == null }}
+    uses: ./.github/workflows/e2e-linux.yml
+    with:
+      grep: "@dummy-test"
+      project: "e2e-browser"
+      display_name: "e2e-browser"
+      currents_tags: "@nightly,@browser/linux"
+    secrets: inherit
 
   slack-notify:
-    # needs: [e2e-electron, e2e-windows, e2e-browser]
-    needs: [e2e-windows]
+    needs: [e2e-electron, e2e-windows, e2e-browser]
     runs-on: ubuntu-latest
     if: always()
     steps:
       - name: Notify Slack
-        uses: midleman/slack-workflow-status@master\
+        uses: midleman/slack-workflow-status@master
         with:
           repo_token: ${{ secrets.POSITRON_GITHUB_PAT }}
           slack_webhook_url: ${{ secrets.SLACK_MARIE_WEBHOOK_URL }}

diff --git a/.github/workflows/pr-merge-push.yml b/.github/workflows/pr-merge-push.yml
@@ -19,9 +19,10 @@ jobs:
     name: test
     uses: ./.github/workflows/e2e-linux.yml
     with:
-      grep: "@pr"
+      grep: ${{ github.event_name == 'pull_request' && '@pr' || github.event_name == 'push' && '' }}
       project: "e2e-electron"
       display_name: "e2e-electron"
+      currents_tags: ${{ github.event_name == 'pull_request' && '@pr' || github.event_name == 'push' && '@push' }}
     secrets: inherit
 
   unit-tests: