Import pypowsybl nominal voltage filter into powsybl-diagram #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agram Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
3 tasks
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
EtienneLt
approved these changes
Dec 4, 2023
flo-dup
requested changes
Dec 5, 2023
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <[email protected]>
3 tasks
Signed-off-by: Sophie Frasnedo <[email protected]>
flo-dup
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Just one comment remaining. But looking at the code now I realize it's partially duplicate, we could factorize the two traverse to avoid this duplication. I think we could do this with a Predicate<VoltageLevel> which would be always true in the basic case, and which would be based on the thresholds for the new filter. Besides, this would enable more complex filtering of voltage levels (might not be very useful though...?)
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
flo-dup
requested changes
Dec 8, 2023
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
Signed-off-by: Sophie Frasnedo <[email protected]>
…e displayed Signed-off-by: Sophie Frasnedo <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Dec 11, 2023
| public static VoltageLevelFilter createVoltageLevelDepthFilter(Network network, String voltageLevelId, int depth) { | ||
| Objects.requireNonNull(network); | ||
| Objects.requireNonNull(voltageLevelId); | ||
| return createVoltageLevelsDepthFilter(network, List.of(voltageLevelId), depth); |
There was a problem hiding this comment.
yes, indeed, this was also duplicate code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
This PR adds a feature that was first coded in pypowsybl to powsybl-diagram. This feature allows network-area diagram users to filter voltage levels according to their nominal voltage.
What is the current behavior?
Such a filter is not available in powsybl-diagram. It is only available for pypowsybl users.
What is the new behavior (if this is a feature change)?
This filter will be available for powsybl-diagram users as well as pypowsybl users.
Other information:
This PR must be followed by another PR in pypowsybl repository to call the powsybl-diagram function and delete the pypowsybl function