-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import pypowsybl nominal voltage filter into powsybl-diagram #566
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
eb66cdd
Import pypowsybl voltage level nominal voltage filter into powsybl-di…
So-Fras 14fac17
Fix 1 code smell
So-Fras f484cf0
Improve code coverage
So-Fras 4141553
Simplify added tests to avoid 2 new code smells
So-Fras 1181a1e
Merge branch 'main' into voltage_filter
So-Fras 738d067
Merge branch 'main' into voltage_filter
So-Fras 814dab1
Changes following review
So-Fras 3d96d05
Fix code smell
So-Fras 1168c00
Replace exception with log warn
So-Fras 9ea2ce6
Refactor traverse method to avoid code duplication
So-Fras 6cabb59
Fix code smells
So-Fras 13095e0
Merge branch 'main' into voltage_filter
So-Fras bfc3431
Change function name (upper bound seems to be the usual term)
So-Fras 43adbe4
Change variable names to keep consistency with function names
So-Fras 951c113
Refactor createVoltageLevelFilter methods to avoid code duplication
So-Fras 06c6dbf
Put static field at the beginning of the class
So-Fras c6ee6ff
Allow input voltage levels that do not comply with the predicate to b…
So-Fras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, indeed, this was also duplicate code!