New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make editor sidebar panel expand when clicked #31082

Open

HenintsoaSky wants to merge 9 commits into ppy:master from HenintsoaSky:expanding-toolbar-click

+68 −2

Open

Make editor sidebar panel expand when clicked #31082

Change tests

GitHub Actions / Results failed Dec 13, 2024 in 1s

43080 passed, 8 failed and 296 skipped

Report	Passed	Failed	Skipped	Time
TestResults-Linux-MultiThreaded.trx	10770✅	2❌	74⚪	2361s
TestResults-Linux-SingleThread.trx	10770✅	2❌	74⚪	1963s
TestResults-Windows-MultiThreaded.trx	10770✅	2❌	74⚪	3074s
TestResults-Windows-SingleThread.trx	10770✅	2❌	74⚪	2498s

❌ TestResults-Linux-MultiThreaded.trx

10846 tests were completed in 2361s with 10770 passed, 2 failed and 74 skipped.

Test suite	Passed	Failed	Skipped	Time
osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer	2✅	2❌		232ms

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

✅ TestConstructor
✅ TestConstructor
❌ TestExpandingToolbox
	sidebar expands after click
❌ TestExpandingToolbox
	sidebar expands after click

❌ TestResults-Linux-SingleThread.trx

10846 tests were completed in 1963s with 10770 passed, 2 failed and 74 skipped.

Test suite	Passed	Failed	Skipped	Time
osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer	2✅	2❌		108ms

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

✅ TestConstructor
✅ TestConstructor
❌ TestExpandingToolbox
	sidebar expands after click
❌ TestExpandingToolbox
	sidebar expands after click

❌ TestResults-Windows-MultiThreaded.trx

10846 tests were completed in 3074s with 10770 passed, 2 failed and 74 skipped.

Test suite	Passed	Failed	Skipped	Time
osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer	2✅	2❌		575ms

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

✅ TestConstructor
✅ TestConstructor
❌ TestExpandingToolbox
	sidebar expands after click
❌ TestExpandingToolbox
	sidebar expands after click

❌ TestResults-Windows-SingleThread.trx

10846 tests were completed in 2498s with 10770 passed, 2 failed and 74 skipped.

Test suite	Passed	Failed	Skipped	Time
osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer	2✅	2❌		355ms

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

✅ TestConstructor
✅ TestConstructor
❌ TestExpandingToolbox
	sidebar expands after click
❌ TestExpandingToolbox
	sidebar expands after click

Annotations

Check failure on line 49 in osu.Game.Tests/Visual/Editing/TestSceneExpandingToolboxContainer.cs

github-actions / Results

osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer ► TestExpandingToolbox

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
  TestResults-Linux-MultiThreaded.trx
Error:
  sidebar expands after click

Raw output


            sidebar expands after click
   at osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer.<TestExpandingToolbox>b__3_1() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/Editing/TestSceneExpandingToolboxContainer.cs:line 49
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.clickAction()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`2 onError, Func`2 stopCondition)
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()

Check failure on line 49 in osu.Game.Tests/Visual/Editing/TestSceneExpandingToolboxContainer.cs

github-actions / Results

osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer ► TestExpandingToolbox

Failed test found in:
  TestResults-Linux-SingleThread.trx
  TestResults-Linux-SingleThread.trx
Error:
  sidebar expands after click

Raw output


            sidebar expands after click
   at osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer.<TestExpandingToolbox>b__3_1() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/Editing/TestSceneExpandingToolboxContainer.cs:line 49
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.clickAction()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`2 onError, Func`2 stopCondition)
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

github-actions / Results

osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer ► TestExpandingToolbox

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
  TestResults-Windows-MultiThreaded.trx
Error:
  sidebar expands after click

Raw output


            sidebar expands after click
   at osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer.<TestExpandingToolbox>b__3_1() in D:\a\osu\osu\osu.Game.Tests\Visual\Editing\TestSceneExpandingToolboxContainer.cs:line 49
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.clickAction()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`2 onError, Func`2 stopCondition)
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()

Check failure on line 0 in TestResults-Windows-SingleThread.trx

github-actions / Results

osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer ► TestExpandingToolbox

Failed test found in:
  TestResults-Windows-SingleThread.trx
  TestResults-Windows-SingleThread.trx
Error:
  sidebar expands after click

Raw output


            sidebar expands after click
   at osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer.<TestExpandingToolbox>b__3_1() in D:\a\osu\osu\osu.Game.Tests\Visual\Editing\TestSceneExpandingToolboxContainer.cs:line 49
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.clickAction()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`2 onError, Func`2 stopCondition)
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)

View more details on GitHub Actions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make editor sidebar panel expand when clicked #31082

Make editor sidebar panel expand when clicked #31082

43080 passed, 8 failed and 296 skipped

❌ TestResults-Linux-MultiThreaded.trx

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

❌ TestResults-Linux-SingleThread.trx

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

❌ TestResults-Windows-MultiThreaded.trx

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

❌ TestResults-Windows-SingleThread.trx

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

Annotations

github-actions / Results

github-actions / Results

github-actions / Results

github-actions / Results

Re-running jobs...

Make editor sidebar panel expand when clicked #31082

Are you sure you want to change the base?

Change tests

Make editor sidebar panel expand when clicked #31082

43080 passed, 8 failed and 296 skipped

❌ TestResults-Linux-MultiThreaded.trx

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

❌ TestResults-Linux-SingleThread.trx

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

❌ TestResults-Windows-MultiThreaded.trx

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

❌ TestResults-Windows-SingleThread.trx

❌ osu.Game.Tests.Visual.Editing.TestSceneExpandingToolboxContainer

Annotations

github-actions / Results

github-actions / Results

github-actions / Results

github-actions / Results

Re-running jobs...