inject request method #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
reviewed
Aug 23, 2024
| @@ -57,6 +57,7 @@ class PraxInjection { | |||
| private stateEvents = new EventTarget(); | |||
|
|
|||
| private injection: Readonly<PenumbraProvider> = Object.freeze({ | |||
| request: () => this.postConnectRequest().then(() => Promise.resolve()), | |||
There was a problem hiding this comment.
issue (blocking): can you add code documentation on the fact that this is temporary and should be removed after a pd point release?
There was a problem hiding this comment.
this was approved by another review, but you've left a blocking comment, so i will avoid merging this unless you re-review.
go ahead and merge this if you intend to include it in a release.
TalDerei
approved these changes
Aug 23, 2024
|
i think this should be part of a fix release, rather than waiting on another solution. |
grod220
approved these changes
Aug 26, 2024
|
Will have to roll this one back. Looks like it works on first page load, but subsequent ones, it cannot make a connection: 
|
Merged
This was referenced Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary fix to mitigate missing request method