Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inject request method #173

Merged
merged 2 commits into from
Aug 26, 2024
Merged

inject request method #173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e2df58
inject request method
turbocrime Aug 22, 2024
f02f95c
comment
turbocrime Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/extension/src/content-scripts/injected-penumbra-global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ class PraxInjection {
private stateEvents = new EventTarget();

private injection: Readonly<PenumbraProvider> = Object.freeze({
/**
* Meet the 'request' method of the old page API to mitigate incompatibility
* with pd v0.80.0's bundled minifront. This prevents connection failure.
* @todo Remove when bundled frontends are updated beyond `a31d54a`
* @issue https://github.com/prax-wallet/web/issues/175
*/
request: () => this.postConnectRequest().then(() => Promise.resolve()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (blocking): can you add code documentation on the fact that this is temporary and should be removed after a pd point release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was approved by another review, but you've left a blocking comment, so i will avoid merging this unless you re-review.

go ahead and merge this if you intend to include it in a release.


connect: () => Promise.resolve(this.port ?? this.postConnectRequest()),
disconnect: () => this.postDisconnectRequest(),
isConnected: () => Boolean(this.port && this.presentState === PenumbraState.Connected),
Expand Down