onboarding and registry #66
Conversation
|
Valentine1898
force-pushed
the
35-onboarding-and-registry-dependency
branch
from
8a3ede4
to
b17ab08
Compare
Valentine1898
force-pushed
the
35-onboarding-and-registry-dependency
branch
from
b17ab08
to
e3df006
Compare
| @@ -39,6 +41,7 @@ const links = [ | |||
| title: 'Price denomination', | |||
| icon: <BarChartIcon className='size-5 text-muted-foreground' />, | |||
| href: PopupPath.SETTINGS_NUMERAIRES, | |||
| disabled: false, | |||
There was a problem hiding this comment.
Can probably just exclude this property
| url: frontend, | ||
| })); | ||
| let registeredFrontends: DisplayedFrontend[] = []; | ||
| try { |
There was a problem hiding this comment.
This shouldn't ever throw right? If that's the case, think we can exclude the try/catch.
| const registryClient = new ChainRegistryClient(); | ||
| const { rpcs } = registryClient.globals(); | ||
| return rpcs.toSorted(randomSort); | ||
| try { |
There was a problem hiding this comment.
Same comment as before. Globals will always be available. So don't think we need to wrap it in try/catch.
|
Also, could you pull the latest registry version from NPM? |
Sure, but to do that you need to update the registry in the packages first |
Closes #35
Screen.Recording.2024-06-28.at.18.41.48.mov
closes #72
fixEmptyGrpcEndpointAfterOnboarding()has been removedUser can re-trigger onboarding at the stage they left off
Screen.Recording.2024-06-28.at.18.47.57.mov