Tests: Multiple Uids Cookies Support #3691
Merged
+289
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
requested changes
Jan 24, 2025
| @@ -16,11 +16,11 @@ class UidsCookie { | |||
| Map<BidderName, UidWithExpiry> tempUIDs | |||
| Boolean optout | |||
|
|
|||
| static UidsCookie getDefaultUidsCookie(BidderName bidder = GENERIC) { | |||
| static UidsCookie getDefaultUidsCookie(BidderName bidder = GENERIC, Integer expireDays = 2) { | |||
There was a problem hiding this comment.
You should choose one name for expiration day(expireDays or plusDays)
| @@ -11,10 +11,10 @@ class UidWithExpiry { | |||
| String uid | |||
| ZonedDateTime expires | |||
|
|
|||
| static UidWithExpiry getDefaultUidWithExpiry() { | |||
| static UidWithExpiry getDefaultUidWithExpiry(Integer plusDays = 2) { | |||
There was a problem hiding this comment.
This one is related to the comment above.
| @@ -6,7 +6,7 @@ import org.prebid.server.functional.model.UidsCookie | |||
| @ToString(includeNames = true, ignoreNulls = true) | |||
| class SetuidResponse { | |||
|
|
|||
| Map<String, String> headers | |||
| LinkedHashMap<String, List<String>> headers | |||
There was a problem hiding this comment.
I believe here Map should be fine.
| @@ -312,14 +335,50 @@ class SetUidSpec extends BaseSpec { | |||
| pbsServiceFactory.removeContainer(pbsConfig) | |||
| } | |||
|
|
|||
| def "PBS SetUid should remove most distant expiration bidder from uids cookie in prioritized bidder"() { | |||
There was a problem hiding this comment.
PBS set uid should emit sizedout metric and remove most distant expiration bidder from uids cookie in prioritized bidder
There was a problem hiding this comment.
Please ad test for sizeblocked.
| assert uidsCookie.tempUIDs[RUBICON] | ||
| } | ||
|
|
||
| def "PBS should sout multiple uids cookies by priority and expiration timestamp"() { |
There was a problem hiding this comment.
typo: send*
PBS should send multiple uids cookies by priority and expiration timestamp
Comment on lines
505
to
507
| then: "Response should contain requested uids" | ||
| assert response.uidsCookie.tempUIDs[GENERIC] | ||
| assert response.uidsCookie.tempUIDs[RUBICON] |
There was a problem hiding this comment.
Wrong description or assert, don't see check uids
…/multiple-uids-cookies
marki1an
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check