-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Multiple Uids Cookies Support #3691
Merged
osulzhenko
merged 6 commits into
multiple-uids-cookies
from
functional-tests/multiple-uids-cookies
Jan 28, 2025
+289
−61
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
43d6b0b
Tests: Multiple Uids Cookies Support
osulzhenko 1c53c93
Merge branch 'refs/heads/multiple-uids-cookies' into functional-tests…
osulzhenko 04bebb0
update functional test
osulzhenko 127a596
update functional tests
osulzhenko a523b7a
Merge branch 'refs/heads/multiple-uids-cookies' into functional-tests…
osulzhenko 702d597
update functional tests
osulzhenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,10 @@ class UidWithExpiry { | |
String uid | ||
ZonedDateTime expires | ||
|
||
static UidWithExpiry getDefaultUidWithExpiry() { | ||
static UidWithExpiry getDefaultUidWithExpiry(Integer plusDays = 2) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one is related to the comment above. |
||
new UidWithExpiry().tap { | ||
uid = UUID.randomUUID().toString() | ||
expires = ZonedDateTime.now(Clock.systemUTC()).plusDays(2) | ||
expires = ZonedDateTime.now(Clock.systemUTC()).plusDays(plusDays) | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ import org.prebid.server.functional.model.UidsCookie | |
@ToString(includeNames = true, ignoreNulls = true) | ||
class SetuidResponse { | ||
|
||
Map<String, String> headers | ||
LinkedHashMap<String, List<String>> headers | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe here Map should be fine. |
||
UidsCookie uidsCookie | ||
Byte[] responseBody | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should choose one name for expiration day(expireDays or plusDays)