Unpack summary screen graphics #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhearachel
requested changes
Nov 11, 2024
There was a problem hiding this comment.
polish: Align this (and other graphics) to be as recognizable as possible, using nitrogfx options for mwidth and mheight to control how they are translated back to NCGRs.
You can use the extra_args keyword argument of generator.process() to supply the additional arguments without needing to write a new generator.
There was a problem hiding this comment.
There's unfortunately a few stubborn ones that can't be made to look nice (pokerus icon, move cursor, ribbon cursor, tabs) but the rest should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpacks all the graphics in the summary screen graphics NARC
pl_pst_gra.narc.There is an issue with NCER generation in nitrogfx that has to be addressed in order for the .jsons in this PR to match, so this will stay as a draft until the relevant nitrogfx PR is merged. It should be ready to review though.