Add Dockerfile #93
Merged
Add Dockerfile #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhearachel
reviewed
Oct 25, 2023
INSTALL.md
Outdated
|
|
||
| ./clean.sh | ||
| docker build . -t pret/pokeplatinum | ||
| docker run -w /rom -v .:/rom pret/pokeplatinum sh -c "./config.sh && ./build.sh" |
There was a problem hiding this comment.
- Does the user need to run
configandbuildeach time? Or is it justbuildafter the initialconfiglike in the existing instructions for desktop environments? - Is the built ROM accessible to the user after it's been built?
There was a problem hiding this comment.
they only need to run config once, and yes the rom is accessible to the user because of the volume mount (-v .:/rom)
lhearachel
approved these changes
Oct 25, 2023
SethBarberee
approved these changes
Oct 25, 2023
|
I also got an OK on Mac, but I had to install an X server (XQuartz, specifically). |
|
It's odd that you needed an X server. This is bad also on linux as more and more people transition to wayland. Try this maybe https://superuser.com/questions/902175/run-wine-totally-headless#948200 Also, why not pip install --user? If the PATH variable isn't picked up properly you can always run /bin/bash -l instead of /bin/sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.