chore(psl): removing parser DB early bailout #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4942 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
…on everything that _is_ valid, then this panic still shouldn't occur, so no need to specifically `create_default_attributes`
…de of the relation might not exist yet.
Druue
changed the title
…ot guarantee a field is either a scalar or relation outside of the QE Co-authored-by: Sergey Tatarintsev <[email protected]>
Druue
changed the title
SevInf
reviewed
Jul 9, 2024
prisma-fmt/tests/hover/scenarios/model_from_model_type_on_broken_relations/schema.prisma
Outdated
Show resolved
Hide resolved
SevInf
reviewed
Jul 9, 2024
psl/psl/tests/validation/composite_types/index_attributes_on_composite_types.prisma
Show resolved
Hide resolved
SevInf
reviewed
Jul 9, 2024
prisma-fmt/tests/hover/scenarios/model_from_model_type_on_broken_relations/schema.prisma
Outdated
Show resolved
Hide resolved
Co-authored-by: Serhii Tatarintsev <[email protected]>
Druue
added a commit
that referenced
this pull request
Jul 10, 2024
* remove early bailout in parser db * We can no longer assume that relation fields exist as the opposite side of the relation might not exist yet. * Added refine_known for usage in QE; refine is now optional as we cannot guarantee a field is either a scalar or relation outside of the QE --------- Co-authored-by: Sergey Tatarintsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #4923