Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(psl): removing parser DB early bailout #4942

Merged
merged 8 commits into from
Jul 9, 2024
Merged

chore(psl): removing parser DB early bailout #4942

merged 8 commits into from
Jul 9, 2024

Commits on Jul 5, 2024

  1. remove early bailout in parser db

    @Druue
    Druue committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    fbd5c0b View commit details
    Browse the repository at this point in the history

  2. restore create_default_attributes if diag.has_errors

    @Druue
    Druue committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    d4df90b View commit details
    Browse the repository at this point in the history

  3. if we don't perform an early bailout and still just parse attributes … 

    …on everything that _is_ valid, then this panic still shouldn't occur, so no need to specifically `create_default_attributes`
    @Druue
    Druue committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1e55377 View commit details
    Browse the repository at this point in the history

  4. We can no longer assume that relation fields exist as the opposite si… 

    …de of the relation might not exist yet.
    @Druue
    Druue committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c91b859 View commit details
    Browse the repository at this point in the history

  5. what do we expect if we try to hover over a relation field that's bro… 

    …ken?
    @Druue
    Druue committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1e9cd7c View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Added refine_known for usage in QE; refine is now optional as we cann… 

    …ot guarantee a field is either a scalar or relation outside of the QE

Co-authored-by: Sergey Tatarintsev <[email protected]>
    @Druue @SevInf
    Druue and SevInf committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    39876e4 View commit details
    Browse the repository at this point in the history

  2. we no longer return early, no need for the comments

    @Druue
    Druue committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fc8531c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Serhii Tatarintsev <[email protected]>
    @Druue @SevInf
    Druue and SevInf committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c95cf6c View commit details
    Browse the repository at this point in the history