Remove case sensitivity for collocate fragment spreads #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinNuc
force-pushed
the
remove-case-sensitivity
branch
2 times, most recently
from
04c3e5c
to
1f2d4ef
Compare
MartinNuc
commented
Aug 29, 2024
MartinNuc
commented
Aug 29, 2024
MartinNuc
force-pushed
the
remove-case-sensitivity
branch
from
1f2d4ef
to
99811cf
Compare
jukben
approved these changes
Aug 30, 2024
|
We should release a new version, right? 🤔 Or how to get it into |
|
@MartinNuc This library and package does not need to be packaged and transpiled for distribution. Create a new version in https://github.com/productboard/pb-frontend/blob/master/package.json#L239
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that we use fragments also in hook and those don't start with the first capital letter therefore I removed the check.
Sorry @comatory , I noticed your PR here after I made these changes and I saw you didn't have test so I would suggest merging mine :-)