Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3039 #3040

Merged
merged 30 commits into from
Oct 18, 2023
Merged

Issue 3039 #3040

merged 30 commits into from
Oct 18, 2023

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Oct 5, 2023

I'm moving former (non-renewing) IPPs to the Additional Supporters section of our /en/supporters, /es/colaboradores, /fr/nos-soutiens, /pt/apoiadores pages.

Closes #3039

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Former (non-renewing) IPPs > Additional Supporters
Make typography consistent, lines 58-76
Former (non-renewing) IPPs > Additional Supporters
Make typography consistent, lines 61-79
Former (non-renewing) IPPs > Additional Supporters
Make typography consistent, lines 59-77
Former (non-renewing) IPPs > Additional Supporters
Make typography consistent, lines 60-80
anisa-hawes and others added 17 commits October 11, 2023 17:03
Update contact, line 110.
Update contact, line 113.
Update contact, line 111.
Update contact, line 114
Update contact at lines 35, 58 and 80.
Update contact at lines 36, 60 and 87.
Update contact at lines 38, 63 and 84.
Update contact at lines 38, 53 and 71.
Add alert-info box to make consistent across /en/ipp, /es/pia, /fr/pi, /pt/ppi
Add html <li> and <div> tags, lines 63-70
Replace Markdown link syntax with html at line 61.
- Create Alumni Partners sub-section
- Move (non-renewing) IPPs to Alumni Partners
- Sub-divide Additional Supporters into active and past
- Create Alumni Partners sub-section
- Move (non-renewing) IPPs to Alumni Partners
- Sub-divide Additional Supporters into active and past
Minor edits, lines 69 and 73
- Create Alumni Partners sub-section
- Move (non-renewing) IPPs to Alumni Partners
- Sub-divide Additional Supporters into active and past
- Create Alumni Partners sub-section
- Move (non-renewing) IPPs to Alumni Partners
- Sub-divide Additional Supporters into active and past
Update month when we reset partnership rates.
Update month when we reset partnership rates.
Update month when we reset partnership rates.
Update month when we reset partnership rates.
@anisa-hawes
Copy link
Contributor Author

anisa-hawes commented Oct 12, 2023

Hello @charlottejmc,

When you have time, may I ask for your help to check my French on the following page?:
ph-preview.netlify.app/fr/nos-soutiens.

What I've done is:

  • Added a new heading Alumni Partners (Partenaires des anciens élèves)
  • Added a description to mean roughly Former contributors to our Institutional Partner Programme (Les institutions suivantes ont participé de notre programme de Partenariat institutionnel). Does this sound right?
  • Added two sub-headings under Additional Supporters (Soutien additionnel) which I'd like to read the equivalent of Active and Past. Would Actifs and Passé seem right?

Thank you 🙂

@charlottejmc
Copy link
Contributor

charlottejmc commented Oct 13, 2023

Hi @anisa-hawes,

I have had a look and here are my thoughts:

  • Partenaires des anciens élèves sounds more like Partners of alumni. I am thinking Anciens élèves partenaires instead – but this is a tricky phrase to translate.
  • This is nearly right: Les institutions suivantes ont participé à notre programme de Partenariat institutionnel is the only correction I can see!
  • I think this could work as it is, although Passé would just need to be in the plural form: Passés. However, I might suggest something along the lines of En cours and Révolus, which could sound more natural? Again, I feel like these are tricky phrases to translate directly.

I hope this helps!

Adjustments to translation at lines 55, 56, 69 and 72.
@spapastamkou
Copy link
Contributor

hi, if I may, for the term "alumni partners", simply "anciens partenaires" ou "partenariats révolus" (as Charlotte proposes) can work here. (as élèves refers to students, and I believe is embarked from the auto translation of the initial alumni term)

@anisa-hawes
Copy link
Contributor Author

anisa-hawes commented Oct 13, 2023

Hello @DanielAlvesLABDH,

I hope you're well. This PR represents some adjustments to the headings and sub-headings on our Supporters pages. Our aim is to create meaningful sub-headings within our lists of IPP, so we make clear who our active supporters are while also acknowledging institutions that have supported us in the past. May I ask for your help to adjust my attempted Portuguese translations?

  • I added a new heading Alumni Partners (Parceiros ex-alunos? or Antigos parceiros?)
  • I added a description to mean roughly Former contributors to our Institutional Partner Programme (Antigos contribuintes para o nosso Programa de Parceria Institucional)
  • I added two sub-headings under Additional Supporters (Apoiadores adicionais) which I'd like to read the equivalent of Active and Past. Would Ativo and Anterior be appropriate?

You can review the detail of my edits here.

With thanks! Anisa

@DanielAlvesLABDH
Copy link
Contributor

Hi @anisa-hawes, will look at this tomorrow morning. Best

pt/apoiadores.md Outdated Show resolved Hide resolved
pt/apoiadores.md Outdated Show resolved Hide resolved
Copy link
Contributor

@DanielAlvesLABDH DanielAlvesLABDH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have made some suggestions of change

Adjust translations lines 57 and 69
@anisa-hawes
Copy link
Contributor Author

Hello @spapastamkou and @rivaquiroga

This PR is ready, with each of the translations checked by native speakers.

The only further change I've made is to update the information about which month we reset partnership rates. As discussed with @drjwbaker and @spapastamkou, going forwards will be reviewing our rates mid-year for reset in October (rather than January) to align with ProgHist Ltd's financial year.

Thank you.

@anisa-hawes anisa-hawes merged commit c4cc807 into gh-pages Oct 18, 2023
4 checks passed
@anisa-hawes anisa-hawes deleted the Issue-3039 branch October 18, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants