-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2531 #3151
Issue 2531 #3151
Conversation
Remove references to Komodo edit (which is now unstable on macOS). Replace with instructions to set up Sublime Text to run Python commands.
Add figure for Hello World in sublime text
Add image for Ola Mundo with Sublime Text
Add image for Hola Mundo with Sublime Text
Hello @jenniferisasi and @ericbrasiln , @anisa-hawes and I have been trying to close a Lesson Maintenance issue which reported the incompatibility of Komodo Edit text editor with MacOS Big Sur (or earlier versions). This affected the en/mac-installation, es/instalacion-mac and pt/instalacao-mac lessons. In our changes to en/mac-installation, we removed mentions of Komodo Edit, and pointed the readers to the text editors BBEdit and Sublime Text instead. In all three lessons, we added a new figure image to show what running 'Hello World'/'Hola Mundo'/'Ola Mundo' would look like in Sublime Text, as well as BBEdit. However, because we weren't able to update the text in Spanish and Portuguese, we could not make the same adjustments for es/instalacion-mac and pt/instalacao-mac as we made for en/mac-installation. Would you be able to review the adjustments we made (remove mention of Komodo Edit, introduce the reader to BBEdit and Sublime Text, and adapt the commands to their interfaces), and replicate them in your respective languages? Thank you very much for your help! ✨ Please do not hesitate to ask me if anything is still unclear. |
I've made the changes to the Portuguese version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @charlottejmc ,
I've revised the changes to the English version and images (they seem okay to me).
I've included the changes to the Portuguese version.
I haven't revised or changed the Spanish version, as I think it's better to wait for Jenifer
Hello @jenniferisasi, Just a gentle nudge to see whether you might have a moment to look at this pull request? You might find it helpful to review the commit which Eric made on the Portuguese version. I see that the Spanish version still shows an image of Komodo Edit ( Thank you very much, and please let me know if you have any questions! Charlotte ✨ |
I edited and translated the changes made to switch the text editor examples used in this lesson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @jenniferisasi and @ericbrasiln have contributed here, I'm happy to approve and merge. Thanks all ✨
This lesson originally suggested to use Komodo Edit as a text editor, but it is unfortunately not compatible with MacOS Big Sur or earlier. We've made changes to the EN lesson especially to suggest readers use BBEdit or Sublime Text instead.
Closes #2531
Checklist
Closes #ISSUENUMBER
to your summary above