-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook up some MTRDevice bits to XPC. #29689
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:MTRDevice-some-XPC
Oct 12, 2023
Merged
Hook up some MTRDevice bits to XPC. #29689
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:MTRDevice-some-XPC
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific changes: * Make MTRDevice get its MTRBaseDevice in a way that is XPC-friendly. * Implement readAttributePaths (which is what ends up getting called by MTRDevice's readAttributeWithEndpointID) over XPC, as long as there is just a single attribute path. * Implement _invokeCommandWithEndpointID (which is what ends up getting called by MTRDevice's _invokeKnownCommandWithEndpointID) over XPC, as long as serverSideProcessingTimeout is nil. * Writes already called an MTRBaseDevice function that was implemented over XPC. * Tests for the new setup; these were checked to fail without the other changes. This also makes MTRClusters work over XPC.
bzbarsky-apple
force-pushed
the
MTRDevice-some-XPC
branch
from
October 10, 2023 17:57
8a0fb5e
to
7d4b7dd
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
October 10, 2023 18:00
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mlepage-google,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 10, 2023 18:00
PR #29689: Size comparison from b9b33a7 to 7d4b7dd Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 12, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Specific changes: * Make MTRDevice get its MTRBaseDevice in a way that is XPC-friendly. * Implement readAttributePaths (which is what ends up getting called by MTRDevice's readAttributeWithEndpointID) over XPC, as long as there is just a single attribute path. * Implement _invokeCommandWithEndpointID (which is what ends up getting called by MTRDevice's _invokeKnownCommandWithEndpointID) over XPC, as long as serverSideProcessingTimeout is nil. * Writes already called an MTRBaseDevice function that was implemented over XPC. * Tests for the new setup; these were checked to fail without the other changes. This also makes MTRClusters work over XPC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific changes:
This also makes MTRClusters work over XPC.