-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DirectModeChange feature to RVC Run Mode and RVC Clean Mode cluster XML and all-clusters-app implementation #35258
Merged
mergify
merged 4 commits into
project-chip:master
from
bzbarsky-apple:add-DirectModeChange-bit
Aug 29, 2024
Merged
Add DirectModeChange feature to RVC Run Mode and RVC Clean Mode cluster XML and all-clusters-app implementation #35258
mergify
merged 4 commits into
project-chip:master
from
bzbarsky-apple:add-DirectModeChange-bit
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 1 of 18 files.
|
bzbarsky-apple
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Aug 28, 2024
kiel-apple
approved these changes
Aug 28, 2024
bzbarsky-apple
force-pushed
the
add-DirectModeChange-bit
branch
from
August 28, 2024 16:29
a1232f4
to
17f3725
Compare
PR #35258: Size comparison from 129ba81 to 17f3725 Full report (7 builds for nxp, qpg, stm32, tizen)
|
kiel-apple
approved these changes
Aug 28, 2024
bzbarsky-apple
force-pushed
the
add-DirectModeChange-bit
branch
from
August 28, 2024 16:53
17f3725
to
32b90ba
Compare
pullapprove
bot
requested review from
arkq,
axelnxp,
bauerschwan,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi and
doru91
August 28, 2024 16:53
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mspang,
p0fi,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
younghak-hwang,
yufengwangca and
yunhanw-google
August 28, 2024 16:53
plauric
reviewed
Aug 29, 2024
plauric
approved these changes
Aug 29, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
…er XML and all-clusters-app implementation (project-chip#35258) * Add DirectModeChange feature to RVC Run Mode and RVC Clean Mode cluster XML. * Run update_cluster_revisions.py to update to the new RVC Run Mode cluster revision. * Run update_cluster_revisions.py to update to the new RVC Clean Mode cluster revision. * Regenerate generated code.
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
review - approved
scripts
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the first commit here is manually written. The rest are auto-generated.
Adding skip-protocol-compatibility, because kNoFeatures is not in fact visible on the protocol level (and should not really have been there to start with, probably, except the Python codegen required some bit).