Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DirectModeChange feature to RVC Run Mode and RVC Clean Mode cluster XML and all-clusters-app implementation #35258

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Aug 28, 2024

Only the first commit here is manually written. The rest are auto-generated.

Adding skip-protocol-compatibility, because kNoFeatures is not in fact visible on the protocol level (and should not really have been there to start with, probably, except the Python codegen required some bit).

Copy link

semanticdiff-com bot commented Aug 28, 2024

Review changes with SemanticDiff.

Analyzed 1 of 18 files.

Filename Status
zzz_generated/app-common/app-common/zap-generated/cluster-enums.h Unsupported file format
src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h Unsupported file format
✔️ src/controller/python/chip/clusters/Objects.py Analyzed
src/controller/data_model/controller-clusters.matter Unsupported file format
src/controller/data_model/controller-clusters.zap Unsupported file format
src/app/zap-templates/zcl/data-model/chip/rvc-clean-mode-cluster.xml Unsupported file format
src/app/zap-templates/zcl/data-model/chip/rvc-run-mode-cluster.xml Unsupported file format
scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/endpoint_config.h Unsupported file format
scripts/tools/zap/tests/inputs/all-clusters-app.zap Unsupported file format
examples/rvc-app/rvc-common/rvc-app.matter Unsupported file format
examples/rvc-app/rvc-common/rvc-app.zap Unsupported file format
examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.zap Unsupported file format
examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.matter Unsupported file format
examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.zap Unsupported file format
examples/chef/common/chef-rvc-mode-delegate.cpp Unsupported file format
examples/all-clusters-app/all-clusters-common/all-clusters-app.matter Unsupported file format
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap Unsupported file format
examples/all-clusters-app/all-clusters-common/src/rvc-modes.cpp Unsupported file format

@bzbarsky-apple bzbarsky-apple added the skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped label Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

PR #35258: Size comparison from 129ba81 to 17f3725

Full report (7 builds for nxp, qpg, stm32, tizen)
platform target config section 129ba81 17f37259 change % change
nxp contact k32w1+release FLASH 590352 590352 0 0.0
RAM 62488 62488 0 0.0
light k32w1+release FLASH 675024 675024 0 0.0
RAM 71472 71472 0 0.0
qpg lighting-app qpg6105+debug FLASH 656300 656300 0 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 614144 614144 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478640 478640 0 0.0
RAM 144716 144716 0 0.0
tizen all-clusters-app arm unknown 4848 4848 0 0.0
FLASH 1710388 1710388 0 0.0
RAM 89376 89376 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17508630 17508638 8 0.0
RAM 7600684 7600684 0 0.0

@mergify mergify bot merged commit 6c6b11f into project-chip:master Aug 29, 2024
68 checks passed
@bzbarsky-apple bzbarsky-apple deleted the add-DirectModeChange-bit branch August 29, 2024 13:47
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Sep 10, 2024
…er XML and all-clusters-app implementation (project-chip#35258)

* Add DirectModeChange feature to RVC Run Mode and RVC Clean Mode cluster XML.

* Run update_cluster_revisions.py to update to the new RVC Run Mode cluster revision.

* Run update_cluster_revisions.py to update to the new RVC Clean Mode cluster revision.

* Regenerate generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app controller darwin examples review - approved scripts skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants